[webkit-reviews] review denied: [Bug 20013] Windows AX heuristics are poor : [Attachment 22593] Patch to expose only Relavant Accessible Objects

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 20013: Windows AX heuristics are poor
https://bugs.webkit.org/show_bug.cgi?id=20013

Attachment 22593: Patch to expose only Relavant Accessible Objects 
https://bugs.webkit.org/attachment.cgi?id=22593&action=edit

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
Sankar, thanks for the patch!

This patch will be much easier to review if it is split up into smaller
patches, and these changes will require layout tests to ensure that the
behavior is correct now and will not regress in the future.

The layout tests should test, for example, that:

<i style="display: block">Test</i> is not ignored and is represented in the
tree as a container element, and

<i role="button">Test</i> is not ignored and is represented in the tree as a
push button.

I am not sure that testing objects by tag name is the right method for this,
because I think that Firefox 3 only ignores elements based on whether they are
inline.

This patch also contains your previous patch's changes to the
children/addChildren methods. Those should be removed.

+    virtual bool isTextFormattingElement() const;
+    virtual bool isLinkOrListItemElement() const;
+    virtual bool isFormOrTableElement() const;
I don't think any of these methods need to be virtual methods on
AccessibilityObject.

r-