[webkit-reviews] review denied: [Bug 20210] Console groups are incorrect when closing and reopening the Inspector : [Attachment 22726] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 13 00:28:42 PDT 2008


Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 20210: Console groups are incorrect when closing and reopening the
Inspector
https://bugs.webkit.org/show_bug.cgi?id=20210

Attachment 22726: patch
https://bugs.webkit.org/attachment.cgi?id=22726&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Better ChangeLog!

The patch seems technically correct, but there are some style issues.

+    //if (arguments.isEmpty())
+    //    addConsoleMessage(new ConsoleMessage(source, StartGroupMessageLevel,
exec, String(), lineNumber, sourceURL, m_groupLevel));
+    //else

We don't comment out code. Just remove it.

Attach a new patch that removes this and i'll r+ it.


More information about the webkit-reviews mailing list