[webkit-reviews] review denied: [Bug 19873] Inspector should support clear() in the command line : [Attachment 22750] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 13 00:23:52 PDT 2008


Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19873: Inspector should support clear() in the command line
https://bugs.webkit.org/show_bug.cgi?id=19873

Attachment 22750: proposed patch
https://bugs.webkit.org/attachment.cgi?id=22750&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
I think this patch looks fine, no technical issues. But please spend some time
on your ChangeLogs. You are missing the Console.cpp and InspectorController.cpp
changes. The prepare-ChangeLog script will do most of the work for you.


More information about the webkit-reviews mailing list