[webkit-reviews] review requested: [Bug 20351] <canvas> code needs fewer #ifdefs : [Attachment 22763] Split out Image cleanup into separate commit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 12 18:13:12 PDT 2008


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 20351: <canvas> code needs fewer #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=20351

Attachment 22763: Split out Image cleanup into separate commit
https://bugs.webkit.org/attachment.cgi?id=22763&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/editing/DeleteButtonController.cpp	    |	10 ++---
 WebCore/loader/CachedImage.cpp 		    |	24 ++++++-------
 WebCore/loader/CachedImage.h			    |	 2 +-
 WebCore/loader/icon/IconRecord.cpp		    |	 6 ++--
 WebCore/loader/icon/IconRecord.h		    |	 2 +-
 WebCore/platform/graphics/BitmapImage.h	    |	17 ++++++---
 WebCore/platform/graphics/GeneratedImage.h	    |	 4 ++
 WebCore/platform/graphics/Gradient.cpp 	    |	 2 +-
 WebCore/platform/graphics/Gradient.h		    |	 5 ---
 WebCore/platform/graphics/Image.cpp		    |	 7 ++++
 WebCore/platform/graphics/Image.h		    |	20 +++++-----
 WebCore/platform/graphics/ImageBuffer.h	    |	39 ++------------------
 .../platform/graphics/cairo/ImageBufferCairo.cpp   |	 8 +---
 WebCore/platform/graphics/cg/ImageBufferCG.cpp     |	 8 ++---
 WebCore/platform/graphics/cg/PDFDocumentImage.h    |	11 +++++-
 WebCore/platform/graphics/gtk/ImageGtk.cpp	    |	 9 ++---
 WebCore/platform/graphics/mac/ImageMac.mm	    |	12 +++----
 WebCore/rendering/RenderImage.cpp		    |	 3 +-
 WebCore/rendering/RenderLayer.cpp		    |	 4 +-
 WebCore/svg/graphics/SVGImage.cpp		    |	11 +-----
 WebCore/svg/graphics/SVGImage.h		    |	11 +++++-
 .../graphics/cairo/SVGPaintServerPatternCairo.cpp  |	 4 ++-
 .../svg/graphics/cairo/SVGResourceMaskerCairo.cpp  |	 8 ++++-
 .../svg/graphics/cg/SVGPaintServerPatternCg.cpp    |	 2 +-
 WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm     |	 2 +-
 25 files changed, 106 insertions(+), 125 deletions(-)


More information about the webkit-reviews mailing list