[webkit-reviews] review requested: [Bug 20351] <canvas> code needs fewer #ifdefs : [Attachment 22764] The final changes needed for Pattern cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 12 18:13:15 PDT 2008


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 20351: <canvas> code needs fewer #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=20351

Attachment 22764: The final changes needed for Pattern cleanup
https://bugs.webkit.org/attachment.cgi?id=22764&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/GNUmakefile.am 			    |	 3 +
 WebCore/WebCore.pro				    |	 2 +
 WebCore/WebCore.vcproj/WebCore.vcproj		    |	28 ++++
 WebCore/WebCore.xcodeproj/project.pbxproj	    |	19 ++-
 WebCore/WebCoreSources.bkl			    |	 1 +
 WebCore/html/CanvasPattern.cpp 		    |  156 +-------------------
 WebCore/html/CanvasPattern.h			    |	58 +-------
 WebCore/html/CanvasRenderingContext2D.cpp	    |  113 +++-----------
 WebCore/html/CanvasRenderingContext2D.h	    |	 4 +-
 WebCore/html/HTMLCanvasElement.cpp		    |	44 ------
 WebCore/html/HTMLCanvasElement.h		    |	24 +---
 WebCore/loader/FrameLoader.cpp 		    |	 6 +-
 WebCore/platform/graphics/GraphicsContext.h	    |	 6 +-
 .../graphics/cairo/GraphicsContextCairo.cpp	    |	17 ++
 WebCore/platform/graphics/cg/GraphicsContextCG.cpp |	33 ++++-
 15 files changed, 145 insertions(+), 369 deletions(-)


More information about the webkit-reviews mailing list