[webkit-reviews] review granted: [Bug 20347] [XBL] Add support for DocumentXBL interface : [Attachment 22738] Proposed implementation, leaving document loading as the rest is not ready

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 20347: [XBL] Add support for DocumentXBL interface
https://bugs.webkit.org/show_bug.cgi?id=20347

Attachment 22738: Proposed implementation, leaving document loading as the rest
is not ready
https://bugs.webkit.org/attachment.cgi?id=22738&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
In general looks fine.	You should change the argument names attrName and name
to be documentURI where appropriate.

You really should be using the newer "fast/js" testing framework, with
shouldBe, etc.	There is TEMPLATE.html inside resources and
make-js-test-wrappers.

In general this looks fine.  I'd like to see you fix the tests to the new
system before landing.	Once you learn it, I think you'll find writing tests
are much easier (just ask WildFox). :)