[webkit-reviews] review denied: [Bug 20364] [XBL] Add shadow tree rendering : [Attachment 22759] First try: add rendering code following SVGUseElement example

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 20364: [XBL] Add shadow tree rendering
https://bugs.webkit.org/show_bug.cgi?id=20364

Attachment 22759: First try: add rendering code following SVGUseElement example
https://bugs.webkit.org/attachment.cgi?id=22759&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
This check looks wrong:
f (templateElement->attached())

tempalteElement is in the xbl doc, no?

this one doens't need braces:
 if (node->hasTagName(XBLNames::templateTag)) {

Otherwise looks fine.

r- for the worng check.  I don't need to see this again, if you can convince me
over IRC that you've put the right check in instead of the templateElement
thing... well, and I guess you should add a test case too! :)