[webkit-reviews] review denied: [Bug 15715] Nested XSL stylesheets can produce memory corruption : [Attachment 22661] new and improved patch with 100% less unnecessary UTF-8 conversions

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Jonathan Haas <myrdred at gmail.com>'s
request for review:
Bug 15715: Nested XSL stylesheets can produce memory corruption
https://bugs.webkit.org/show_bug.cgi?id=15715

Attachment 22661: new and improved patch with 100% less unnecessary UTF-8
conversions
https://bugs.webkit.org/attachment.cgi?id=22661&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good except...

Should use spaces, not tabs:
9298	 bool m_stylesheetDocTaken;
 99	XSLStyleSheet* m_parentStyleSheet;

This needs a comment to explain why this is done:
+    if (parentStyleSheet()) {
+	 xmlDictFree(ctxt->dict);
+	 ctxt->dict = parentStyleSheet()->m_stylesheetDoc->dict;
+    }
Really the code could just use a comment or two in general to tell why we're
stuffing away this parent document pointer, and under which circumstances we
could ever stop...

Also, this needs a test case which demonstrates the crash.   Your test case
should work under run-webkit-tests and should crash before your patch and not
after your patch.

Thanks for the patch!