[webkit-reviews] review requested: [Bug 20294] Move more Frame methods into ScriptController : [Attachment 22670] Move more methods from Frame into ScriptController
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 5 17:59:00 PDT 2008
Eric Seidel <eric at webkit.org> has asked for review:
Bug 20294: Move more Frame methods into ScriptController
https://bugs.webkit.org/show_bug.cgi?id=20294
Attachment 22670: Move more methods from Frame into ScriptController
https://bugs.webkit.org/attachment.cgi?id=22670&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/WebCore.NPAPI.exp | 3 +-
WebCore/WebCore.base.exp | 6 +-
WebCore/WebCore.xcodeproj/project.pbxproj | 4 +
WebCore/bindings/js/ScriptController.cpp | 134 +++++++++++++++++++-
WebCore/bindings/js/ScriptController.h | 54 ++++++++
WebCore/bindings/objc/DOM.mm | 3 +-
WebCore/bindings/objc/DOMInternal.mm | 2 +-
WebCore/bridge/jni/jni_jsobject.mm | 2 +-
WebCore/html/HTMLAppletElement.cpp | 33 +----
WebCore/html/HTMLAppletElement.h | 11 +--
WebCore/html/HTMLEmbedElement.cpp | 40 ++-----
WebCore/html/HTMLEmbedElement.h | 11 +--
WebCore/html/HTMLObjectElement.cpp | 32 +----
WebCore/html/HTMLObjectElement.h | 2 +-
WebCore/html/HTMLPlugInElement.cpp | 72 +++++------
WebCore/html/HTMLPlugInElement.h | 12 +-
WebCore/loader/FrameLoader.cpp | 12 +-
WebCore/page/Frame.cpp | 120 ++----------------
WebCore/page/Frame.h | 44 +------
WebCore/page/FramePrivate.h | 42 +------
WebCore/page/gtk/FrameGtk.cpp | 30 -----
WebCore/page/mac/FrameMac.mm | 141 +++------------------
WebCore/page/qt/FrameQt.cpp | 96 --------------
WebCore/page/win/FrameWin.cpp | 48 +-------
WebKit/mac/Plugins/WebBaseNetscapePluginView.mm | 5 +-
WebKit/mac/Plugins/WebPluginController.mm | 5 +-
WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm | 6 +-
WebKit/mac/WebView/WebFrame.mm | 2 +-
WebKit/mac/WebView/WebScriptDebugger.mm | 25 ++--
WebKit/mac/WebView/WebView.mm | 2 +-
30 files changed, 328 insertions(+), 671 deletions(-)
More information about the webkit-reviews
mailing list