[webkit-reviews] review denied: [Bug 20221] [Qt] ToggleBold, ToggleItalic, and ToggleUnderline page actions should update during navigation. : [Attachment 22547] Adds support for updating more editing related actions.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Erik L. Bunce
<elbunce at thehive.com>'s request for review:
Bug 20221: [Qt] ToggleBold, ToggleItalic, and ToggleUnderline page actions
should update during navigation.
https://bugs.webkit.org/show_bug.cgi?id=20221

Attachment 22547: Adds support for updating more editing related actions.
https://bugs.webkit.org/attachment.cgi?id=22547&action=edit

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I agree with the patch in principle (thanks!), but there are a few minor
cosmetic glitches:

1) Please make the editorCommandWebActions array local to qwebpage.cpp by
prepending 'static'.

2) You commented out the cases for all the editor actions and handle it in
default: instead. That's fine, but I don't think we should leave the old code
commented out, please just remove it :)

3) The last item in the array should probably not end with a comma :)

r- because of those, but I'd be happy to r+ with them fixed.