[webkit-reviews] review requested: [Bug 19656] [SOUP] The gio code should call didFail() instead of didFinishLoading() in case of error : [Attachment 22629] Call didFail in case of error

[bugzilla-daemon at webkit.org]

Marco Barisione <marco.barisione at collabora.co.uk> has asked  for review:
Bug 19656: [SOUP] The gio code should call didFail() instead of
didFinishLoading() in case of error
https://bugs.webkit.org/show_bug.cgi?id=19656

Attachment 22629: Call didFail in case of error
https://bugs.webkit.org/attachment.cgi?id=22629&action=edit

------- Additional Comments from Marco Barisione
<marco.barisione at collabora.co.uk>
Adding something like GOwnPtr and GObjectPtr could be a good idea but it's
something for a separate patch.

"So we make 2 copies of the buffer just to send this URI off to ResourceError. 

Is it possible to avoid this?"

What do you mean? The copy from the GFile to a char and then to a String? In
this case I don't see any solution.