[webkit-reviews] review denied: [Bug 19676] [Gtk] text-shadow should apply to text decorations as well : [Attachment 21914] Updated patch due to changes from bug #19727

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>'s request for review:
Bug 19676: [Gtk] text-shadow should apply to text decorations as well
https://bugs.webkit.org/show_bug.cgi?id=19676

Attachment 21914: Updated patch due to changes from bug #19727
https://bugs.webkit.org/attachment.cgi?id=21914&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Isn't "drawLineForText" used for drawing underlines?

Also this seems like kinda a gross hack.  But maybe this is the cleanest way to
do this with Cairo.

Also, you don't respect Shadow-blur.  I think that we should come up with a
better way of drawing Cairo shadows instead of this.

A shadow is a second copy of the entire image drawn at an offset and blurred.