[webkit-reviews] review denied: [Bug 19578] [CURL] problem in parseDataUrl : [Attachment 21727] fix the base64 problem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 1 16:50:21 PDT 2008


Eric Seidel <eric at webkit.org> has denied Mario Bensi <mbensi at pleyo.com>'s
request for review:
Bug 19578: [CURL] problem in parseDataUrl
https://bugs.webkit.org/show_bug.cgi?id=19578

Attachment 21727: fix the base64 problem
https://bugs.webkit.org/attachment.cgi?id=21727&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
We don't use malloc() and free directly.  We use fastMalloc() and fastFree()
when possible, or new/delete.

Also, this should just be held in an OwnPtr or an OwnArrayPtr so that it's
automatically cleaned up when the block is exited.

No reason to use manual c-style memory management when we have nicer c++ tools.
:)


More information about the webkit-reviews mailing list