[webkit-reviews] review requested: [Bug 18749] SQUIRRELFISH: const support is broken : [Attachment 20884] Proposed patch

[bugzilla-daemon at webkit.org]

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 18749: SQUIRRELFISH: const support is broken
http://bugs.webkit.org/show_bug.cgi?id=18749

Attachment 20884: Proposed patch
http://bugs.webkit.org/attachment.cgi?id=20884&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Here's a patch that fixes the 2 const tests and doesn't regress on any other
tests. It works, but I think it would be served with some better abstraction of
the indices in the SymbolTable from the actual entries.

I am going to do some performance testing now. If stealing a bit is too
expensive then we may need to have two separate hash tables for non-const and
const entries.