[webkit-reviews] review granted: [Bug 11939] Quirksmode: Ignores media types in stylesheet PIs : [Attachment 20847] Moved from bug 18657

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 28 23:14:51 PDT 2008

Eric Seidel <eric at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 11939: Quirksmode: Ignores media types in stylesheet PIs

Attachment 20847: Moved from bug 18657

------- Additional Comments from Eric Seidel <eric at webkit.org>
Great!	r=me.  However, I would prefer that you fix setMedia to take a
PassRefPtr while you're in that code.  It takes a raw ptr, but does take
ownership of it (so your code doesn't leak) but at first glance it looks like
it does.  setMedia pre-dates PassRefPtr I think.

More information about the webkit-reviews mailing list