[webkit-reviews] review denied: [Bug 17873] Encoding override should not be persistent : [Attachment 19821] patch v2 for fixing this problem by using different way

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 28 04:46:39 PDT 2008

Alexey Proskuryakov <ap at webkit.org> has denied johnnyding
<johnnyding.webkit at gmail.com>'s request for review:
Bug 17873: Encoding override should not be persistent

Attachment 19821: patch v2 for fixing this problem by using different way

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
As mentioned above, I do not have enough evidence to agree that the current
behavior is broken from the user point of view. I was also going to say that we
cannot change the semantics of -[WebView setCustomTextEncodingName:] API, but
then I noticed that its own documentation (as well as a comment in WebView.h)
says "The text encoding automatically goes back to the default when the top
level frame changes to a new location."

The difference seems to be too elaborate to be a simple bug. Perhaps there is a
longer story behind this?

This patch as is breaks sites such as <http://www.mdf.ru/>, so I don't think
that we want to take it. Firefox seems to have the same problem, although its
charset auto-detection is very configurable, and it is possible that its
ability to remember previously chosen overrides can remedy that in some cases.

There is certainly an issue to fix here, but I think that it would probably be
appropriate to treat this as a documentation bug.

More information about the webkit-reviews mailing list