[webkit-reviews] review cancelled: [Bug 17873] Encoding override should not be persistent : [Attachment 19792] patch v1 for fixing this problem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 28 04:21:50 PDT 2008


Alexey Proskuryakov <ap at webkit.org> has cancelled johnnyding
<johnnyding.webkit at gmail.com>'s request for review:
Bug 17873: Encoding override should not be persistent
http://bugs.webkit.org/show_bug.cgi?id=17873

Attachment 19792: patch v1 for fixing this problem
http://bugs.webkit.org/attachment.cgi?id=19792&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Clearing review flag, since this breaks the build. To fix the build, one could
add __ZNK7WebCore14DocumentLoader16overrideEncodingEv to WebCore.exp, but I
think that it would be better not to hide the tricky logic behind this
innocent-looking function.


More information about the webkit-reviews mailing list