[webkit-reviews] review requested: [Bug 17331] Change postMessage/MessageEvent to match HTML5 wrt. exposing origin vs. domain/uri : [Attachment 20631] Updated patch to address aroben's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 17 11:45:43 PDT 2008


Collin Jackson <collinj-webkit at collinjackson.com> has asked  for review:
Bug 17331: Change postMessage/MessageEvent to match HTML5 wrt. exposing origin
vs. domain/uri
http://bugs.webkit.org/show_bug.cgi?id=17331

Attachment 20631: Updated patch to address aroben's comments
http://bugs.webkit.org/attachment.cgi?id=20631&action=edit

------- Additional Comments from Collin Jackson
<collinj-webkit at collinjackson.com>
Restored deprecated "domain" API to WebSecurityOrigin.mm
Renamed "origin" argument to "targetOrigin" in DOMWindow and JSDOMWindowCustom

There aren't any changes required for DumpRenderTree/win because it doesn't
implement setDatabaseQuota. (It probably should... do we have a bug for that?)

Bitrot fixes:
Updated the new SecurityOrigin constructors to handle the new ThreadSafeShared
behavior in r31971.
The addMessageToConsole method disappeared in r31951, changed to call
Console::addMessage


More information about the webkit-reviews mailing list