[webkit-reviews] review requested: [Bug 18518] Implement eval in SquirrelFish : [Attachment 20630] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has asked  for review:
Bug 18518: Implement eval in SquirrelFish
http://bugs.webkit.org/show_bug.cgi?id=18518

Attachment 20630: patch
http://bugs.webkit.org/attachment.cgi?id=20630&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Since the patch worked for Cameron, I think I'll put it up for review.

New changes in this version: Fixed exception propagation from "this.eval".
Changed eval codegen to use resolve_base_and_func instead of
resolve_base_and_property, so "this" is right if eval is declared as a local in
a function. Renamed emitEval to emitCallEval, to match the earlier opcode
rename I did.