[webkit-reviews] review denied: [Bug 18471] Fix WebDownload.cpp compile problems for cairo/curl build : [Attachment 20518] divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 14 08:11:23 PDT 2008


Adam Roben (aroben) <aroben at apple.com> has denied Daniel Zucker
<zucker at wake3.com>'s request for review:
Bug 18471: Fix WebDownload.cpp compile problems for cairo/curl build
http://bugs.webkit.org/show_bug.cgi?id=18471

Attachment 20518: divide WebDownload.cpp into WebDownloadCurl.cpp and
WebDownloadCFNet.cpp
http://bugs.webkit.org/attachment.cgi?id=20518&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
It looks like this patch has a mixture of spaces and tabs in it. Please only
use 4 spaces for indentation.

I think we'd ultimately be better served by moving the concept of a "download"
to WebCore and having the platform differences reside at that level. Having two
whole implementations of WebDownload doesn't feel like the right solution to
me.


More information about the webkit-reviews mailing list