[webkit-reviews] review denied: [Bug 18393] Move POST cache policy from platform dependent file : [Attachment 20439] Patch to move cache setting

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied David Carson <dacarson at gmail.com>'s
request for review:
Bug 18393: Move POST cache policy from platform dependent file
http://bugs.webkit.org/show_bug.cgi?id=18393

Attachment 20439: Patch to move cache setting
http://bugs.webkit.org/attachment.cgi?id=20439&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 Move setting cache policy out of platform dependant implementation.

Misspelling of dependent here.

     // FIXME: Where's the code that implements what the comment above says?
+    // ANSWER: The cache policy is set in loadItem()

This is a bit silly. Lets remove the "FIXME" if there's nothing that needs
fixing.

		 if (ResourceHandle::willLoadFromCache(request))
+		     request.setCachePolicy(ReturnCacheDataDontLoad);
		     action = NavigationAction(itemURL, loadType, false);
		 else {

This won't compile unless you add braces.

review- because it won't compile.