[webkit-reviews] review denied: [Bug 18393] Move POST cache policy from platform dependent file : [Attachment 20439] Patch to move cache setting

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 12 23:24:21 PDT 2008

Darin Adler <darin at apple.com> has denied David Carson <dacarson at gmail.com>'s
request for review:
Bug 18393: Move POST cache policy from platform dependent file

Attachment 20439: Patch to move cache setting

------- Additional Comments from Darin Adler <darin at apple.com>
+	 Move setting cache policy out of platform dependant implementation.

Misspelling of dependent here.

     // FIXME: Where's the code that implements what the comment above says?
+    // ANSWER: The cache policy is set in loadItem()

This is a bit silly. Lets remove the "FIXME" if there's nothing that needs

		 if (ResourceHandle::willLoadFromCache(request))
+		     request.setCachePolicy(ReturnCacheDataDontLoad);
		     action = NavigationAction(itemURL, loadType, false);
		 else {

This won't compile unless you add braces.

review- because it won't compile.

More information about the webkit-reviews mailing list