[webkit-reviews] review denied: [Bug 13097] Unsupported content:inherit value : [Attachment 20372] Implements 'inherit' value for 'content'

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 12 23:29:04 PDT 2008

Darin Adler <darin at apple.com> has denied Vincent Ricard
<magic at magicninja.org>'s request for review:
Bug 13097: Unsupported content:inherit value

Attachment 20372: Implements 'inherit' value for 'content'

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for taking this on. Looks like a good first cut.

A few things need fixing.

If you're going to implement inherit, then you need to remove the following
now-inaccurate comment:

	 // FIXME: In CSS3, it will be possible to inherit content.  In CSS2 it
is not.  This
	 // note is a reminder that eventually "inherit" needs to be supported.

And replace it with a new one.

+/*		       case CONTENT_QUOTE:
+			 m_style->setContent(content->m_content.m_quote);
+			 break;*/

We don't check in commented-out code like this in the WebKit project.

The test case is inadequate. For example, it doesn't exercise the
CONTENT_OBJECT or CONTENT_COUNTER cases in the newly-added switch statement.
The only type of inheritance it checks is inheriting nothing.

Also, are we guaranteed that m_parentStyle is non-0? I think you could probably
create a test case where content: inherit is in a style without a parent, and
then we'd dereference null in the inherit code.

review- because of these issues.

More information about the webkit-reviews mailing list