[webkit-reviews] review denied: [Bug 16447] onload called too many times for <svg:image> : [Attachment 20490] Better approach

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 12 11:00:32 PDT 2008

Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 16447: onload called too many times for <svg:image>

Attachment 20490: Better approach

------- Additional Comments from Eric Seidel <eric at webkit.org>

I don't think static RefPtr is "safe".	the Event object would end up shared
between frames, and would be unsafe.  Data could survive on the JSEvent wrapper
too (since those are generally cached based on pointer).

I think that <image> should delay its onload until after its resources are
loaded and ready to render anyway.  I'm not sure what that means for
externalResourcesRequired on <image> then...

r- for the Event sharing issue.

More information about the webkit-reviews mailing list