[webkit-reviews] review requested: [Bug 16447] onload called too many times for <svg:image> : [Attachment 20490] Better approach

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 12 06:41:34 PDT 2008

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 16447: onload called too many times for <svg:image>

Attachment 20490: Better approach

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This patch keeps the intend of the current code, delaying parent load
dispatching until the image is loaded for externalResourcesRequired=true. Also
it makes sure the event is dispatched to the parent node, the current code used
"this"! With the new checks there are no multiple load dispatches.

Comparing with other implementations is a bit hard; Opera does not seem to
support externalResourcesRequired, saying:

Failed attribute on image element: externalResourcesRequired="true".

Both and FireFox and Opera just seem to dispatch the load for the image right
after parsing the tag, but I don't think this is what the spec indicates.

The malloc avoiding code is just an idea I have, and could be dealt with
separately, though while messing with the load code I think it is convenient
to attack that problem too.


More information about the webkit-reviews mailing list