[webkit-reviews] review requested: [Bug 18357] [GTK] Enter on buttons doesn't work : [Attachment 20402] Set the text of the event to '\r' when the return/enter key is pressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 8 03:06:49 PDT 2008


Marco Barisione <marco.barisione at collabora.co.uk> has asked  for review:
Bug 18357: [GTK] Enter on buttons doesn't work
http://bugs.webkit.org/show_bug.cgi?id=18357

Attachment 20402: Set the text of the event to '\r' when the return/enter key
is pressed
http://bugs.webkit.org/attachment.cgi?id=20402&action=edit

------- Additional Comments from Marco Barisione
<marco.barisione at collabora.co.uk>
Note that I used '\r' instead of '\n' because it's what WebCore use. Probably
it's better to use '\n' modifying WebCore to allow this, but I think there
could be a lot of places in WebCore where the code assumes that enter is '\r'.
What do you think?


More information about the webkit-reviews mailing list