[webkit-reviews] review granted: [Bug 18329] REGRESSION: Assertion failure in -[WebViewFactory endOfTextMarkerRange:] when invoking the Dictionary pop-up : [Attachment 20401] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 8 01:48:48 PDT 2008


mitz at webkit.org has granted Alice Liu <alice.liu at apple.com>'s request for
review:
Bug 18329: REGRESSION: Assertion failure in -[WebViewFactory
endOfTextMarkerRange:] when invoking the Dictionary pop-up
http://bugs.webkit.org/show_bug.cgi?id=18329

Attachment 20401: patch
http://bugs.webkit.org/attachment.cgi?id=20401&action=edit

------- Additional Comments from mitz at webkit.org
Please add the bug URL and title to the change log.

+    if (textMarker != nil)
+    if (textMarkerRange != nil)

According to the style guidelines these should be written as
+    if (textMarker)
+    if (textMarkerRange)

r=me


More information about the webkit-reviews mailing list