[webkit-reviews] review denied: [Bug 15299] GTK: ChromeClientGtk.cpp does not implement mouseDidMoveOverElement() : [Attachment 16459] Possible implementation for ChromeClient::mouseDidMoveOverElement()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 29 15:28:32 PDT 2007


Adam Roben <aroben at apple.com> has denied Lars Lindner
<lars.lindner at gmail.com>'s request for review:
Bug 15299: GTK: ChromeClientGtk.cpp does not implement
mouseDidMoveOverElement()
http://bugs.webkit.org/show_bug.cgi?id=15299

Attachment 16459: Possible implementation for
ChromeClient::mouseDidMoveOverElement()
http://bugs.webkit.org/attachment.cgi?id=16459&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+    } else {
+	 g_signal_emit_by_name(m_webPage, "hovering_over_link", NULL, NULL);   

+    }

As specified on <http://webkit.org/coding/coding-style.html>, please omit the
braces around the single-line body of the else block. We also use 0 instead of
NULL since this is C++ code.

We normally put the bug title and URL in the ChangeLog entry as well.

This looks great, though! Fix up those things and I'll r+ it.



More information about the webkit-reviews mailing list