[webkit-reviews] review denied: [Bug 14126] Shell scripts to build WebKit should be forced to LF endings : [Attachment 16432] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 29 14:46:29 PDT 2007


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Satoshi Ueyama
<gyuque at gmail.com>'s request for review:
Bug 14126: Shell scripts to build WebKit should be forced to LF endings
http://bugs.webkit.org/show_bug.cgi?id=14126

Attachment 16432: Patch v2
http://bugs.webkit.org/attachment.cgi?id=16432&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>@@ -68,6 +68,8 @@ while (<IN>) {
>     chomp;
>     my $prop = $_;
> 
>+	$prop =~ s/[\r\n]+$//;

The chomp statement isn't necessary with the added line.  (Sorry, I should have
caught this with the first review.)

Please remove the chomp statement, repost the patch, and r=me.



More information about the webkit-reviews mailing list