[webkit-reviews] review requested: [Bug 15228] Missing flex, bison, or gperf produces a failing build : [Attachment 16317] Updated fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 18 13:41:18 PDT 2007


Tuukka Hastrup <Tuukka.Hastrup at iki.fi> has asked  for review:
Bug 15228: Missing flex, bison, or gperf produces a failing build
http://bugs.webkit.org/show_bug.cgi?id=15228

Attachment 16317: Updated fix
http://bugs.webkit.org/attachment.cgi?id=16317&action=edit

------- Additional Comments from Tuukka Hastrup <Tuukka.Hastrup at iki.fi>
Actually the initial patch prints an error message for the first command that
can't be executed, followed by the message about the list of all required
commands. 

But why not take one more step towards usability indeed. I've updated the patch
according to the feedback, requesting a new review. Example output:

~/svn/WebKit$ WebKitTools/Scripts/build-webkit --gdk
Can't exec "flex": No such file or directory at
/home/tuukka/svn/WebKit/WebKitTools/Scripts/webkitdirs.pm line 497.
Can't exec "gperf": No such file or directory at
/home/tuukka/svn/WebKit/WebKitTools/Scripts/webkitdirs.pm line 497.
flex, gperf missing but required to build WebKit.
~/svn/WebKit$



More information about the webkit-reviews mailing list