[webkit-reviews] review denied: [Bug 15223] webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt : [Attachment 16313] Updated patch

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Julien Chaffraix
<julien.chaffraix at gmail.com>'s request for review:
Bug 15223: webkitdir.pm::isQt() is not working properly in run-webkit-tests
under Linux/Qt
http://bugs.webkit.org/show_bug.cgi?id=15223

Attachment 16313: Updated patch
http://bugs.webkit.org/attachment.cgi?id=16313&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+sub determineIsGdk ()

Please remove the space before the parentheses.

+	 if (defined($platformParameter)) {
+	     $buildResult = system "WebKitTools/Scripts/build-dumprendertree",
$configurationOption, $platformParameter;
+	 } else {
+	     $buildResult = system "WebKitTools/Scripts/build-dumprendertree",
$configurationOption; 
+	 }

You don't need to check defined($platformParameter) here. You can just pass it
to system, since passing undef is the same as not passing anything at all.

Thanks for all the fixes so far!