[webkit-reviews] review denied: [Bug 15223] webkitdir.pm::isQt() is not working properly in run-webbkit-test under Linux/Qt : [Attachment 16301] proposed patch

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Julien Chaffraix
<julien.chaffraix at gmail.com>'s request for review:
Bug 15223: webkitdir.pm::isQt() is not working properly in run-webbkit-test
under Linux/Qt
http://bugs.webkit.org/show_bug.cgi?id=15223

Attachment 16301: proposed patch
http://bugs.webkit.org/attachment.cgi?id=16301&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
We prefer not to export global variables from perl modules. I think you should
follow the "x()/determineX()" pattern we use throughout webkitdirs.pm:

my $isQt;
sub determineIsQt()
{
    return if defined($isQt);
    $isQt = <something>;
}

sub isQt()
{
    determineIsQt();
    return $isQt;
}