[webkit-reviews] review requested: [Bug 15223] webkitdir.pm::isQt() is not working properly in run-webbkit-test under Linux/Qt : [Attachment 16301] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 16 14:47:51 PDT 2007


Julien Chaffraix <julien.chaffraix at gmail.com> has asked  for review:
Bug 15223: webkitdir.pm::isQt() is not working properly in run-webbkit-test
under Linux/Qt
http://bugs.webkit.org/show_bug.cgi?id=15223

Attachment 16301: proposed patch
http://bugs.webkit.org/attachment.cgi?id=16301&action=edit

------- Additional Comments from Julien Chaffraix <julien.chaffraix at gmail.com>
With this patch, when calling isQt (same for isGdk), the comparison is done
once. The result is stored in a global variable and is given in the following
code.

The global variables ($isQt and $isGdk) are now exported to be used in
buid-dumprendertree.

The saving / regeneration of $isQt was removed in run-webkit-tests as it is not
necessary anymore (done directly in isQt()).



More information about the webkit-reviews mailing list