[webkit-reviews] review denied: [Bug 14998] Full page zooming support : [Attachment 16217] Add zoom functionality to GdkLauncher for testing purposes

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied George Wright
<george.wright at collabora.co.uk>'s request for review:
Bug 14998: Full page zooming support
http://bugs.webkit.org/show_bug.cgi?id=14998

Attachment 16217: Add zoom functionality to GdkLauncher for testing purposes
http://bugs.webkit.org/attachment.cgi?id=16217&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
style issues:
+    webkit_gtk_page_set_scale_factor(gPage, scaleFactor * 1.2);
..
+    webkit_gtk_page_set_scale_factor(gPage, scaleFactor / 1.2);

However i'd prefer a integer representing the scale level, which you then
modified, eg:
+static void menuMainZoomInCallback(gpointer)
+{
+    if (scaleFactor < 10)
+	 scaleFactor++;
+    webkit_gtk_page_set_scale_factor(gPage, scaleFactor * whatever);
+}
+
+static void menuMainZoomOutCallback(gpointer)
+{
+    if (scaleFactor > 0)
+	 scaleFactor--;
+    webkit_gtk_page_set_scale_factor(gPage, scaleFactor * whatever);
+}

Which would mean that you wouldn't get cumulative rounding error over time.