[webkit-reviews] review requested: [Bug 14868] Import variable lookup optimizations from KJS : [Attachment 16215] Revised proposed patch

[bugzilla-daemon at webkit.org]

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 14868: Import variable lookup optimizations from KJS
http://bugs.webkit.org/show_bug.cgi?id=14868

Attachment 16215: Revised proposed patch
http://bugs.webkit.org/attachment.cgi?id=16215&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Here's a revised patch. It has the following differences:

- it now patches cleanly against ToT.
- I cleaned up some style problems, like a few ASSERT usages that I somehow
missed
- I added test cases for the direct write bugs. The array one wouldn't actually
fail for any version of the code, because AssignBracketNode doesn't do direct
writes.

I hope I didn't miss anything. There is only one bad thing of which I am aware.
When I run the entirety of the layout tests or just fast/dom,
fast/dom/constructors-overriding.html will sometimes crash, but I can't get it
to crash on its own. The crash is in ActivationImp::mark(), which is modified
by this patch. It doesn't seem to crash without the patch (I didn't try on my
machine, I am just going by the build bot and Mark).