[webkit-reviews] review requested: [Bug 14766] S60 browser finditem should be able to find VoIP address : [Attachment 16210] New patch after changes based on the previous review

[bugzilla-daemon at webkit.org]

George Guo <george.guo at nokia.com> has asked Sachin Padma
<Sachin.Padma at nokia.com> for review:
Bug 14766: S60 browser finditem should be able to find VoIP address
http://bugs.webkit.org/show_bug.cgi?id=14766

Attachment 16210: New patch after changes based on the previous review
http://bugs.webkit.org/attachment.cgi?id=16210&action=edit

------- Additional Comments from George Guo <george.guo at nokia.com>
The following changes were made: 
(1) Voip call command was enabled
(2) Two if statements were combined in webkitcursor.cpp 
(3) Format were checked. 
Furthermore the belowing is the test results
* Find phone number still work				pass
* Find Keyword still work				pass
* Find Email address still work 			pass
* Find IP address can find email and phone		pass
* Find VoIP can find 3 digits from 123ok		pass 
* Find VoIP can go back to the beginning at the end	pass 
* Turn on the smart text recoginition work		pass
* After text recogniztion on, do the above tests	pass 



voip call command is not in browser control commands. Check formatting issues.
There are two if statements in webkitcursor.cpp that can be combined when
assigning cursor image.