[webkit-reviews] review denied: [Bug 12988] First element (in document order) is not returned when other duplicate ID-ed elements were created first : [Attachment 16179] More complete patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 12988: First element (in document order) is not returned when other
duplicate ID-ed elements were created first
http://bugs.webkit.org/show_bug.cgi?id=12988

Attachment 16179: More complete patch
http://bugs.webkit.org/attachment.cgi?id=16179&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This patch no longer applies, because I rolled out your original fix. So you
need a new patch that works without first applying your old patch (a
combination of both).

But your patch also has what I consider a memory leak.

If you write a loop that adds two elements with an id, then calls
getElementById on that id, then removes both elements, in a loop, with your
patch the m_duplicateIds set will keep getting bigger and bigger, because the
code leaks a duplicate id in that case. I think we don't want that behavior.

I think my approach is better even though the patch is bigger.