[webkit-reviews] review requested: [Bug 12988] First element (in document order) is not returned when other duplicate ID-ed elements were created first : [Attachment 16179] More complete patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 12988: First element (in document order) is not returned when other
duplicate ID-ed elements were created first
http://bugs.webkit.org/show_bug.cgi?id=12988

Attachment 16179: More complete patch
http://bugs.webkit.org/attachment.cgi?id=16179&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
Firsr of all, apologies for missing the fact that two svg tests broke, I kind
of assumed some svg tests were broken because of other things. Second, I'd like
to get it fixes asap so we can move on :)
This patch is basically the lisppaste snippet plus Darin's comments taken into
account. I worded half of it myself but also took one sentence from Darin's
patch. Note that the new patch does not alter removeElementById, that was a
mistake in my first patch pointed out by Maciej. I have a slight tendency
towards my patch since it is close to the original code, but again the main
thing IMHO is too resolve the problem soon :)
Cheers,

Rob.