[webkit-reviews] review denied: [Bug 15409] FrameLoaderClientGtk hardcodes data, including platform to Linux i686 : [Attachment 16574] Use uname(3) to read the sysname + machine

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Ed Schouten <ed at fxq.nl>'s request for
review:
Bug 15409: FrameLoaderClientGtk hardcodes data, including platform to Linux
i686
http://bugs.webkit.org/show_bug.cgi?id=15409

Attachment 16574: Use uname(3) to read the sysname + machine
http://bugs.webkit.org/attachment.cgi?id=16574&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
The error handling of the call to uname seems a bit dodgy -- do we really want
to have a user-agent string that doesn't have any system/architecture at all?

This definitely seems like a step in the right direction, but I think we can
make this fix even more complete pretty easily:

1. As Mark said, the WebKit version number should match the one used on OS X,
since that's what most websites will be checking for
(<http://trac.webkit.org/projects/webkit/wiki/DetectingWebKit>).
2. As Mark said, the "X11" part of the user-agent string may not always be
correct -- what about Gtk+ on Win32?
3. Also in the Win32 vein, I don't think Win32 has a uname function, so I don't
think this code will compile on Gtk+/Win32. But maybe we don't care about that?


r- for now so we can figure out the above issues.