[webkit-reviews] review requested: [Bug 15669] Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port : [Attachment 17561] Updated patch to use x11 instead of !mac:!win32-*:!directfb

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 27 15:37:39 PST 2007


Rodney Dawes <dobey at wayofthemonkey.com> has asked  for review:
Bug 15669: Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port
http://bugs.webkit.org/show_bug.cgi?id=15669

Attachment 17561: Updated patch to use x11 instead of !mac:!win32-*:!directfb
http://bugs.webkit.org/attachment.cgi?id=17561&action=edit

------- Additional Comments from Rodney Dawes <dobey at wayofthemonkey.com>
Here's an updated patch. This patch requires the patch in bug 16146 to land, in
order to work correctly. Without it, the code will build, but XP_UNIX will not
be defined, and -lXt will not be added to LIBS.

I've also removed the NP_OBJECT enabling part from this patch. There's
apparently another piece that needs to be enabled as well, so I will enable
that, and submit a separate patch for it.


More information about the webkit-reviews mailing list