[webkit-reviews] review requested: [Bug 14730] [curl] Cookie handling : [Attachment 17560] First draft (cookie handling)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 27 12:48:36 PST 2007

Julien Chaffraix <julien.chaffraix at gmail.com> has asked  for review:
Bug 14730: [curl] Cookie handling

Attachment 17560: First draft (cookie handling)

------- Additional Comments from Julien Chaffraix <julien.chaffraix at gmail.com>
This patch imports the OWB cookie management both for handling, refusing and
storing cookies.

The points that remain are :
- writing cookies to a file should occur only when the CookieManager is
destroyed. My idea was to do that in the destructor of the
ResourceHandleManager but it is never called (my workaround is to write it each
time a cookie is added)
- I have left all the original comments and logging for discussion

Any comments appreciated.

More information about the webkit-reviews mailing list