[webkit-reviews] review granted: [Bug 12216] Stack overflow crash
in JavaScript garbage collector mark pass : [Attachment
17552] [5/6] Not reviewed.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 27 09:33:09 PST 2007
Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 12216: Stack overflow crash in JavaScript garbage collector mark pass
http://bugs.webkit.org/show_bug.cgi?id=12216
Attachment 17552: [5/6] Not reviewed.
http://bugs.webkit.org/attachment.cgi?id=17552&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
7 This seems tobe a wash on SunSpider.
Missing space here.
42 // used to push JSValue** or PopertyMapEntry* ranges
Missing "r" here.
I'm concerned that the change to property_map.h might cause a compilation
failure on platforms that don't compile all at once. You may need to move an
include from the .cpp to the .h.
r=me
More information about the webkit-reviews
mailing list