[webkit-reviews] review granted: [Bug 12216] Stack overflow crash in JavaScript garbage collector mark pass : [Attachment 17551] [4/6] Not reviewed.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 12216: Stack overflow crash in JavaScript garbage collector mark pass
http://bugs.webkit.org/show_bug.cgi?id=12216

Attachment 17551: [4/6] 	Not reviewed.
http://bugs.webkit.org/attachment.cgi?id=17551&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks like the ChangeLog has some duplication in it.

 34	    void push(JSValue* value);
 35	    void push(JSCell* cell);

 38	    void pushAtom(JSValue* value);
 39	    void pushAtom(JSCell* cell);

 47	    void reserveCapacity(size_t size);

No need to name the arguments here.

 45	    bool isEmpty();
 46	    size_t size();

These should be const.

I'd slightly prefer for loops for these:

 101	     while (start != end) {
...
 109		 ++start;

I can read them better than a while with a ++.

 155	     // after processing arange on the stack there is always at

Missing space in "arange".

r=me