[webkit-reviews] review requested: [Bug 16052] prepare-ChangeLog doesn't report deleted files : [Attachment 17523] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 25 22:36:45 PST 2007


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 16052: prepare-ChangeLog doesn't report deleted files
http://bugs.webkit.org/show_bug.cgi?id=16052

Attachment 17523: Patch v2
http://bugs.webkit.org/attachment.cgi?id=17523&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Simpler fix.

If there were only removed files, the prepare-ChangeLog script would always
report no changes because the check for !%function_lists did not work as
expected.  We now check for !keys %function_lists instead, and make sure there
are no changed files (added, modified), no conflicted files and no removed
files.


More information about the webkit-reviews mailing list