[webkit-reviews] review granted: [Bug 16128] ignore resizable=no for window.open() : [Attachment 17512] patch v1.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 25 20:58:36 PST 2007


Adam Roben <aroben at apple.com> has granted rahul abrol <ra5ul at comcast.net>'s
request for review:
Bug 16128: ignore resizable=no for window.open()
http://bugs.webkit.org/show_bug.cgi?id=16128

Attachment 17512: patch v1.1
http://bugs.webkit.org/attachment.cgi?id=17512&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
-     The IE rule is: all features except for channelmode and fullscreen
default to YES, but
-     if the user specifies a feature string, all features default to NO.
(There is no public
-     standard that applies to this method.)
-     
+     The IE rule is: all features except for channelmode and fullscreen
default to YES, but if the user specifies a feature string, all features
default to NO. (There is no public standard that applies to this method.)

I think the newlines here should be restored.

r=me, but whoever lands this should fix the above issue.


More information about the webkit-reviews mailing list