[webkit-reviews] review denied: [Bug 15530] XMLHttpRequest should not support certain methods : [Attachment 17429] Patch + test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 21 05:48:12 PST 2007

Alexey Proskuryakov <ap at webkit.org> has denied Julien Chaffraix
<julien.chaffraix at gmail.com>'s request for review:
Bug 15530: XMLHttpRequest should not support certain methods

Attachment 17429: Patch + test case

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+    layoutTestController.waitUntilDone();

This is not needed.

+    try {
+	 xhr.open(method, "resources/1251.html", true);
+	 xhr.send(null);

This test doesn't differentiate between open() and send() raising an exception,
I think it should.

It may be slightly better to use sync XHR in the test, to maqke it more
explicit that we don't wait for anything to finish.

More information about the webkit-reviews mailing list