[webkit-reviews] review denied: [Bug 16036] Further cleanup to PCRE : [Attachment 17383] [PATCH] Remove no longer used error code JSRegExpErrorMatchLimit

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Eric Seidel <eric at webkit.org>'s request
for review:
Bug 16036: Further cleanup to PCRE
http://bugs.webkit.org/show_bug.cgi?id=16036

Attachment 17383: [PATCH] Remove no longer used error code
JSRegExpErrorMatchLimit
http://bugs.webkit.org/attachment.cgi?id=17383&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
I think if you remove a error code it is a good idea to make the range
continuous again (make JSRegExpErrorRecursionLimit = -4)
as we aren't keeping any kind of compatibility here.

This change seems like it should go in the patch that originally made the
comment.
- Currently that's 100000 - 16 * (23 * 4)  ~ 9MB
+ Currently that's 100000 - 16 * (23 * 4)  ~ 90MB

r-