[webkit-reviews] review granted: [Bug 16036] Further cleanup to
PCRE : [Attachment 17381] [PATCH] Make i locally scoped for
better code clarity
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 20 15:00:19 PST 2007
Sam Weinig <sam at webkit.org> has granted Eric Seidel <eric at webkit.org>'s request
for review:
Bug 16036: Further cleanup to PCRE
http://bugs.webkit.org/show_bug.cgi?id=16036
Attachment 17381: [PATCH] Make i locally scoped for better code clarity
http://bugs.webkit.org/attachment.cgi?id=17381&action=edit
------- Additional Comments from Sam Weinig <sam at webkit.org>
Bad bad Eric. This code will decrement the i counter twice as much. Also, the
indenting is off.
- i = 255;
- while (!opcode_jump_table[i])
- opcode_jump_table[i--] = &&CAPTURING_BRACKET;
+ for (int i = 255; !opcode_jump_table[i]; i--)
+ opcode_jump_table[i--] = &&CAPTURING_BRACKET;
Otherwise, this looks great. r=me.
More information about the webkit-reviews
mailing list