[webkit-reviews] review cancelled: [Bug 15993] PCRE needs a bath : [Attachment 17284] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 14 16:56:25 PST 2007

Eric Seidel <eric at webkit.org> has cancelled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 15993: PCRE needs a bath

Attachment 17284: the patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
This now includes some additional cleanup I'd been working on for my next
patch.	However using -b to ignore whitespace makes for a smaller patch even
with those extra changes.  I can get you the original diff ignoring whitespace
if that would be easier.

My additional changes were to add a constructor to compile_data and to break
out the debug printf code into its own separate function.  I also added
returnError to replace the PCRE_ERROR_RETURN goto.

Yay for more-readable code!

More information about the webkit-reviews mailing list