[webkit-reviews] review requested: [Bug 15993] PCRE needs a bath : [Attachment 17285] Add a couple more minor cleanups to PCRE, -b diff

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 15993: PCRE needs a bath
http://bugs.webkit.org/show_bug.cgi?id=15993

Attachment 17285: Add a couple more minor cleanups to PCRE, -b diff
http://bugs.webkit.org/attachment.cgi?id=17285&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
This now includes some additional cleanup I'd been working on for my next
patch.	However using -b to ignore whitespace makes for a smaller patch even
with those extra changes.  I can get you the original diff ignoring whitespace
if that would be easier.

My additional changes were to add a constructor to compile_data and to break
out the debug printf code into its own separate function.  I also added
returnError to replace the PCRE_ERROR_RETURN goto.

Yay for more-readable code!