[webkit-reviews] review requested: [Bug 15938] Inspector/Qt requires patch to SecurityOrigin : [Attachment 17188] Use FrameLoader::shouldTreatURLAsLocal from SecurityOrigin::canAccess

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 11 13:26:03 PST 2007

Holger Freyther <freyther at handhelds.org> has asked  for review:
Bug 15938: Inspector/Qt requires patch to SecurityOrigin

Attachment 17188: Use FrameLoader::shouldTreatURLAsLocal from

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Remove the unused m_portSet. Remove m_host, m_protocol and m_port in favor of
storing a KURL directly. Use KURL::isLocalFile instead of comparing to "file"
directly. Avoid calling lower() on (Deprecated)String but use the case
insensitive compare besides in ::setFrame.

Like the last patch no regressions were introduced and please take a look at it
in regard to:

More information about the webkit-reviews mailing list